POC: remove unneeeded Uri / UriBuilder allocations
#1914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMakkison
changed the title
Uri / UriBuilder allocationsUri / UriBuilder allocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment: move query logic from
RequestBuilderImplementationtoRestMethodInfo, ecaping as needed.Demonstrates some suspiciously good memory savings. I imagine this is from not allocating
Uri56 bytes,UriBuilder88 bytes and calling variousUrimethods (variable around 600 bytes). Unfortunately, this is broken under ceratin conditions 🤷 This can be fixed but will require rigorous testing.Updated (on battery power)
Old
dotMemory profile - Divide memory value by 1000 to get the actual allocations